Replace libmemcached Git submodule with binary package #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-90-remove-libmemcached-submodule
branch
2 times, most recently
from
8884161
to
6b458a5
Compare
ligurio
force-pushed
the
ligurio/gh-90-remove-libmemcached-submodule
branch
2 times, most recently
from
e2824d3
to
2d4b4c3
Compare
ligurio
force-pushed
the
ligurio/gh-90-remove-libmemcached-submodule
branch
from
2d4b4c3
to
f996965
Compare
|
Moved to drafts because libmemcached git submodule used for building benchmark memcaslap, see #90 (comment) |
|
I'll discard the review request while it is in draft. Feel free to ask a review when it'll be ready or if you'll have specific questions. I added my opinion into the discussion in the issue. |
libmemcached is a project that provides a library with implemenation of memcached protocol and a number of tools for working with memcached servers. memcached uses memcapable [1] that checks memcached server implemenation for conformance with memcached protocol. libmemcached available as binary packages on Ubuntu (memcapable is in libmemcached-tools, see [2]) and no reasons to keep libmemcached as a Git submodule and spend time on it's compilation and maintenance. 1. http://docs.libmemcached.org/bin/memcapable.html 2. https://packages.ubuntu.com/focal/libmemcached-tools Closes #90
ligurio
force-pushed
the
ligurio/gh-90-remove-libmemcached-submodule
branch
from
f996965
to
1d47fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90