-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail upload request early when possible #26
Comments
Yep. |
AFAIU, now we report success for an upload request with any files (even if we mistakely request to upload something that is not a package). I found it very counter-intuitive. |
I don't see a logical dependency on #2. We can validate all files first and then upload them non-transactionally. Those tasks look orthogonal. |
No. We check file extensions. |
IMHO we must to check all files and either upload all or not upload any file of the package. |
As I see from PR tarantool/mkrepo#27, mkrepo may fail metainformation update due to a malformed package. So, we can call those
parse_deb()
andparse_info()
functions directly (before uploading files and calling mkrepo to generate the metainfo) and decline upload if something goes wrong: respond with a 4xx code.This way a developer will receive a feedback about a malformed package (or a problem in rws) earlier.
The text was updated successfully, but these errors were encountered: