Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NISTIonizationEnergies accesses a NIST website that sometimes rejects access #391

Open
andrewfullard opened this issue Jan 18, 2024 · 2 comments

Comments

@andrewfullard
Copy link
Contributor

This causes tests to fail and would affect running Carsus from non-institutional connections, as well as running into timeouts.

@nvieira-mcgill
Copy link

What exactly does the error traceback look like for this? I am getting the following when I use NISTIonizationEnergies in any way:

  File "/home/nvieira/carsus/lib/python3.6/site-packages/carsus-0.1.dev0-py3.6.egg/carsus/io/nist/ionization.py", line 310, in __init__
    self.parser = NISTIonizationEnergiesParser(input_data)
  File "/home/nvieira/carsus/lib/python3.6/site-packages/carsus-0.1.dev0-py3.6.egg/carsus/io/base.py", line 37, in __init__
    self.load(input_data)
  File "/home/nvieira/carsus/lib/python3.6/site-packages/carsus-0.1.dev0-py3.6.egg/carsus/io/nist/ionization.py", line 84, in load
    for a in pre_tag.find_all("a"):
AttributeError: 'NoneType' object has no attribute 'find_all'

I'm using an older version of carsus (which I'm currently updating in case that fixes anything) but have never encountered this issue, and am wondering if this is the issue I'm facing.

@andrewfullard
Copy link
Contributor Author

This is partially resolved by pointing to our mirror https://github.com/tardis-sn/carsus/blob/master/carsus/io/nist/ionization.py#L28 but we also pull the version from NIST directly, which may become mismatched in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants