-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving gcode to chilipeppr doesn't work? #35
Comments
It shows my gmail address, yes. |
Odd. I'll ask John if he has any ideas. |
If there's anything else I should try, let me know. If you can give a quick summary of how the login code works (and/or where to find it), I could have a closer look myself. |
The login check happens at https://github.com/tbfleming/jscut/blob/gh-pages/js/jscut.js#L779 |
Hm, I guess chilipeppr is not returning any user. If I try it in the console:
|
The odd part: it works for me |
See if you are signed into www.chilipeppr.com and chilipeppr.com. Google seems to treat them differently. |
I'm shown as logged in on both. I tried logging out on www.chilipeppr.com and logging in again, but that didn't fix it (not sure if it changed anything). Now, when I go to http://www.chilipeppr.com/datalogin directly, it shows my login. On http://chilipeppr.com/datalogin it shows null. When I open chilipeppr itself, it makes a request to http://www.chilipeppr.com/datalogin?callback=jQuery21007010580077767372_1421782156152&_=1421782156153, with an I should have mentioned this before, but I'm using Chromium 39 for testing. I just also tried Google Chrome 39, which works as expected (and sends the cookie). So perhaps Chromium is somehow more pedantic about cross-domain requests here? |
Ah-ha! I wonder if that means a future version of Chrome will break this. |
Interesting. This is a jsonp trick. Jsonp is pretty standard now but I could see tighter security in future. There are other ways to pull this off |
Another data point: I just did a fresh install of Ubuntu 14.04 on a VM then installed Chromium 39. It worked. Here's the version string: Version 39.0.2171.65 Ubuntu 14.04 (64-bit) Which distribution are you using? |
You left out the most important part of the datapoint: Does it work? :-) I have Version 39.0.2171.71 Built on 8.0, running on Debian 8.0 (64-bit) |
Yes. |
Wow Debian has slow mirrors. Ubuntu spoiled me. Another data point soon. |
Slow install after fetch also. I wonder how Ubuntu sped it up. |
This failed: |
If we're lucky, then .71 has a bug that didn't exist in .65 and was fixed by .99. If we're unlucky, then Chromium tightened up security and it will eventually make it to Chrome. |
I just upgraded chromium and it still doesn't work there: Version 41.0.2272.76 Built on 8.0, running on Debian 8.0 (64-bit) Upgraded google-chrome does work: Version 41.0.2272.101 (64-bit) Note that "work" means that no login error is shown and /datalogin returns correct data, but instead "undefined" is shown in the upper right of jscut and I can't see any file in chilipeppr. No time to dig into this right now, but at least it seems to be an unrelated issue. So, it seems that this is not just a bug in a single Chromium build - Debian is building Chromium with some change, patch or configuration that breaks these requests for some reason. |
I just tried saving the generated gcode to chilipeppr.com, but it says "Not logged into http://chilipeppr.com/" (in an easy-to-miss popup in the background). I just logged into chilipeppr.com (and refreshed both chilipeppr and jscut afterwards), so that cannot be true.
Any thoughts?
The text was updated successfully, but these errors were encountered: