Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: add parameter for 'step' #4

Open
nmanzi opened this issue Oct 11, 2021 · 2 comments · May be fixed by #5
Open

feature request: add parameter for 'step' #4

nmanzi opened this issue Oct 11, 2021 · 2 comments · May be fixed by #5
Assignees
@nmanzi
Labels
enhancement New feature or request

Comments

@nmanzi
Copy link

nmanzi commented Oct 11, 2021

Thanks for RRDRest! It's helping me with a project to collect LibreNMS RRD data for reporting with PowerBI.

Quick feature req that I'm happy to work on and submit a PR for, it'd be nice if I could specify the step that gets passed to rrdtool.
@tbotnz
Copy link
Owner

tbotnz commented Oct 11, 2021

No worries @nmanzi, seems like a good idea. Plz use optional http query param

@tbotnz tbotnz added the enhancement New feature or request label Oct 11, 2021
nmanzi added a commit to nmanzi/RRDReST that referenced this issue Oct 11, 2021
@nmanzi
implement tbotnz#4 with optional 'step' param
3a4af9f
@nmanzi nmanzi linked a pull request Oct 11, 2021 that will close this issue
Open
nmanzi added a commit to nmanzi/RRDReST that referenced this issue Oct 11, 2021
@nmanzi
Feature/4 step param (#1)
a2c774e 
* implement tbotnz#4 with optional 'step' param

* update readme
@nmanzi
Copy link
Author

nmanzi commented Oct 13, 2021

Hi @tbotnz, PR #5 submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmanzi nmanzi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement #4 'step' parameter nmanzi/RRDReST
2 participants
@nmanzi @tbotnz