Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shading for persistence diagram #14

Open
rrrlw opened this issue Jul 21, 2020 · 2 comments
Open

shading for persistence diagram #14

rrrlw opened this issue Jul 21, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@rrrlw
Copy link
Member

rrrlw commented Jul 21, 2020

image

could we consider adding the option to shade the bottom-right triangular half of persistence diagrams? (example image above)

@corybrunson
Copy link
Member

I could see how this could be used to distinguish ordinary persistence diagrams from extended persistence diagrams, if both are used in the same project, or just as a cue to the viewer to ignore the southeast triangle. (I don't know how common it is, but it seems natural enough to want.) It should be doable using GeomPolygon internally, though it might be tricky to ensure that the legs of the triangle line up exactly with the plot window.

@rrrlw rrrlw added the enhancement New feature or request label Sep 1, 2020
@corybrunson
Copy link
Member

corybrunson commented Jul 8, 2022

I suggest making this an option of geom_diagonal().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants