Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests run on windows #9

Open
euclidianAce opened this issue Apr 7, 2021 · 4 comments
Open

Ensure tests run on windows #9

euclidianAce opened this issue Apr 7, 2021 · 4 comments
Labels
help wanted Extra attention is needed os:windows

Comments

@euclidianAce
Copy link
Member

Additionally, find some way to run CI for windows as leafo's github actions do not support it. So either fix that upstream or find a different method.

  • maybe use chocolatey - luarocks package is pretty outdated, we use the 3.0 format so that wouldn't work
  • manually install everything - would work, but I'd have to learn what windows-latest comes with on github actions. for example can I curl/wget a luarocks binary? and add it to the PATH
  • See if there's another github action that supports windows
@euclidianAce euclidianAce added this to the 0.1 milestone Apr 7, 2021
@euclidianAce
Copy link
Member Author

I have made a futile attempt to patch leafo's github action to support windows. It fetches and builds Lua perfectly fine, the issue seems to be with adding it to the path. I have no idea what the trouble is, luajit seems to work fine but it makes a symlink somewhere instead/in addition to adding to PATH. So I have no idea

@euclidianAce euclidianAce added the help wanted Extra attention is needed label Apr 9, 2021
@euclidianAce
Copy link
Member Author

I think I'll push this back to the 0.2 milestone as I've used cyan on windows a little bit and it seems to work for the most part. I'd like to focus on a little bit of polish for the first release. CI can be worried about after that.

If anybody knows of a good github action to use, I'm all ears. Otherwise my tentative plan is to maybe write a custom action for hererocks

@euclidianAce euclidianAce modified the milestones: 0.1, 0.2 May 3, 2021
@hishamhm
Copy link
Member

I'm also curious about this! I have just converted the LuaRocks CI from Travis CI to Github Actions — just for Linux and Mac, though; Windows still runs on Appveyor. So If anyone finds a way to run Github Actions for Lua stuff on Windows cleanly, I'm also interested! Tackling this is not a priority for me now since Appveyor is working fine, but it would be nice to simplify things.

@hishamhm
Copy link
Member

@euclidianAce Keep an eye on leafo/gh-actions-luarocks#14 :)

@euclidianAce euclidianAce modified the milestones: 0.2, 0.3 Aug 16, 2022
@euclidianAce euclidianAce modified the milestones: 0.3, 0.4 Feb 2, 2023
@euclidianAce euclidianAce removed this from the 0.4 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed os:windows
Projects
None yet
Development

No branches or pull requests

2 participants