Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of getObjectDelta #914

Open
Losses opened this issue Oct 3, 2022 · 0 comments
Open

Incorrect implementation of getObjectDelta #914

Losses opened this issue Oct 3, 2022 · 0 comments

Comments

@Losses
Copy link

Losses commented Oct 3, 2022

I'm not sure what is this line of code trying to express, but an empty object won't equal to anything except itself, propertyDelta != {} will always return false.

LokiJS/src/lokijs.js

Line 5164 in 25b9a33

if (typeof propertyDelta !== "undefined" && propertyDelta != {}) {

@techfort @ChristopherTapLogic
@Losses Losses changed the title Incorrect implementation of getObjectDelta Incorrect implementation of getObjectDelta Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Losses