Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Redis Driver Server Options wrong syntax #346

Open
tstrijdhorst opened this issue Mar 16, 2017 · 2 comments
Open

Documentation: Redis Driver Server Options wrong syntax #346

tstrijdhorst opened this issue Mar 16, 2017 · 2 comments

Comments

@tstrijdhorst
Copy link

tstrijdhorst commented Mar 16, 2017

http://www.stashphp.com/Drivers.html#redis

The example code is wrong. Given:

// One Server
$driver = new Stash\Driver\Redis();
$driver->setOptions(array('servers' => array('127.0.0.1', '6379')));

Should be:

// One Server
$driver = new Stash\Driver\Redis();
$driver->setOptions(array('servers' => array(array('127.0.0.1', '6379'))));

Edit:

Same goes for Memcache Driver:

// One Server
$driver = new Stash\Driver\Memcache();
$driver->setOptions(array('servers' => array('127.0.0.1', '11211')));
@alexbowers
Copy link
Contributor

This needs checking and a pull request being sent into https://github.com/tedious/www.stashphp.com

@tstrijdhorst
Copy link
Author

Ah I didn't realise the website was in a repo as well. If I find any more inconsistencies while traversing the docs I will create a PR there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants