Opcache clear sometimes fails with a fatal error

[KorvinSzanto]

This line in the FileSystem driver will sometimes fail with a fatal error in environments where the opcache api is restricted using the opcache.restrict_api configuration. This issue has plagued some of the niche members of our community and has caused them to manually modify this dependency by hand.

Should we make this line @opcache_invalidate($path, true) instead? I think another worse option is to eval the contents of the file instead of include.

[ghost]

Another possibility would possibly be to add a check for opcache.enable => On in https://github.com/tedious/Stash/blob/master/src/Stash/Driver/FileSystem.php#L239

[KorvinSzanto]

@sylphidlw That makes a little sense, but I think the issue these users are having a lot of the time is that they DO have opcache enabled, they just have api access restrictions. That does bring up a point that I somehow spaced though, we can just directly check that opcache.restrict_api value.

[zeefarmer]

@KorvinSzanto,

That was also a suggestion here.

opcache.restrict_api
Allows calling OPcache API functions only from PHP scripts which path is started from specified string. The default "" means no restriction.

So if you first checked whether or not opcache is enabled, then check the value of opcache.restrict_api for anything other than "", then disable the API functions.

[tedivm]

If anyone wants to take this on the recommend solution is to have it throw an error when the system is in this state.