Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TextSplitter for very long sentences. #15

Open
PhilipMay opened this issue Jun 4, 2023 · 1 comment
Open

Improve TextSplitter for very long sentences. #15

PhilipMay opened this issue Jun 4, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@PhilipMay
Copy link
Member

PhilipMay commented Jun 4, 2023 •
edited
Loading

Improve so we split the sentence instead raising an exception.

see

mltb2/mltb2/somajo_transformers.py

Line 55 in 29fd020

raise ValueError("No sentence may be longer than 'max_token'.")

@PhilipMay PhilipMay changed the title Improve TextSplitter with very long sentences. Improve TextSplitter for very long sentences. Jun 5, 2023
@PhilipMay
Copy link
Member Author

PhilipMay commented Jun 6, 2023 •
edited
Loading

small improvement is in this PR: #16 - but not done yet.

@PhilipMay PhilipMay added enhancement New feature or request help wanted Extra attention is needed labels Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilipMay