Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler: Parser is required, even when not used #236

Open
KristianLyng opened this issue May 30, 2022 · 0 comments
Open

Handler: Parser is required, even when not used #236

KristianLyng opened this issue May 30, 2022 · 0 comments
Labels
core/modules Anything dealing with the general module support enhancement New feature or request receiver Receiver-related

Comments

@KristianLyng
Copy link
Collaborator

I think we need a better way to verify handlers. It's rather pointless to require a parser that's never used, but by removing that requirement, the individual receivers need to verify this somehow. It's easy to do at run-time in Parse(), but that isn't exposed to Verify-logic, so ./skogul -show wont detect this, and besides, it adds a pointless op for every single parsed byte sequence.

Ideally I'd like this to be largely transparent to receivers, but that might not be possible.

@KristianLyng KristianLyng added enhancement New feature or request receiver Receiver-related core/modules Anything dealing with the general module support labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/modules Anything dealing with the general module support enhancement New feature or request receiver Receiver-related
Projects
None yet
Development

No branches or pull requests

1 participant