Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GOB (and avro) encoder and parser #240

Merged
merged 78 commits into from
Aug 23, 2022
Merged

Implement GOB (and avro) encoder and parser #240

merged 78 commits into from
Aug 23, 2022

Conversation

RoshiniNara
Copy link
Contributor

fixes #227 and #228

RoshiniNara and others added 17 commits June 13, 2022 22:52
@RoshiniNara
gob parser is added. auto module is updated to include the gob parser
f083c86
@RoshiniNara
Gob encoder is added and auto module is updated to include the gob en…
78f679e 
…coder.
@RoshiniNara
Auto module is updated.
f68e890
@RoshiniNara
Auto module is updated.
49adf69
@RoshiniNara
Update auto.go
f4d85cb
@RoshiniNara
gog_test file (not compiling due to import errors)
4391ad8
@RoshiniNara
Update gob_test.go
91987ee
@vnragavan
Encoder updated in test and the source
6b09045
@vnragavan
updated test and gob file - test is still failing due to container mi…
1da420a 
…smatch
@vnragavan
encoder_test is successful
ad030ed
@vnragavan
Updated author info
6590a5c
@vnragavan
GOB parser tests sucessful
8bdb13f
@vnragavan
Updated author information
5702385
@vnragavan
Parser interface is fixed. Tests are updated.
d873b70
@RoshiniNara
Parser test function name updated.
96cb4ba
@vnragavan
Configurations files for gob encoder and parser.
ea16343
@vnragavan
Merge branch 'primary' of https://github.com/RoshiniNara/skogul into …
857f23f 
…primary
KristianLyng
KristianLyng requested changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@KristianLyng KristianLyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just some minor issues I've commented on. The biggest - beyond the test failures - is that config/https_gob_to_stdout.json and config/tester_to_https_gob.json needs to be moved. Configuration examples live in docs/examples and since these two are related, I suggest adding a new directory called docs/examples/avro/ and putting both in there instead, ideally a short README.rst explaining what they do - something short is fine, see for example docs/examples/kafka/README.rst for a short example.

Some background: Everything in config/ is the actual code responsbile for parsing and applying configuration files, not meant for storing actual configuration. Conversely, everything in docs/ is distributed when you install Skogul on a machine, and every configuration file in docs/examples/ will be automatically tested for validity (i.e.: testet if it parses, not actually run) on "make check".

encoder/auto.go Show resolved Hide resolved
encoder/auto.go Outdated Show resolved Hide resolved
encoder/gob_test.go Show resolved Hide resolved
encoder/gob_test.go Outdated Show resolved Hide resolved
parser/auto.go Outdated Show resolved Hide resolved
parser/auto.go Outdated Show resolved Hide resolved
parser/gob.go Show resolved Hide resolved
@KristianLyng KristianLyng changed the title Implement GOB encoder and parser Implement GOB (and avro) encoder and parser Aug 11, 2022
RoshiniNara and others added 25 commits August 12, 2022 00:29
@RoshiniNara
sync.once is added to avro encoder and parser. Also, error condition …
ebec6c2 
…is checked.
@RoshiniNara
sync once change added
adfd3c1
@RoshiniNara
Update avro.go
f91a3d7
@RoshiniNara
Update avro.go
1440ce0
@RoshiniNara
Update avro.go
1dd7340
@RoshiniNara
Update avro.go
d1c3fe4
@RoshiniNara
avro parser error fixed
d78264e
@RoshiniNara
error fixed : removed
b49561f
@RoshiniNara
update auto.go
333d957
@RoshiniNara
Updated eith the errors in auto file
4dda447
@RoshiniNara
Removed the error message in line#47
f355580
@RoshiniNara
avro tests (fails due to timestamp error)
523e7b8
@RoshiniNara
avro updates
75d43b9
@RoshiniNara
avro test updated
fa94198
@RoshiniNara
avro test failes due to incorrect arguments
cb08c54
@RoshiniNara
avro encoder test passed
1f218e8
@RoshiniNara
added encoder test to thge parser terst module
eda0ad3
@RoshiniNara
parser test updated
939de68
@RoshiniNara
avro encoder removed
0cd37e6
@RoshiniNara
changed pass by reference to the avro parser
ad221e1
@RoshiniNara
Added pass by reference to the AVRO encoder
8a188d3
@RoshiniNara
Update avro.go
6eb1709
@RoshiniNara
Update avro.go
25ff855
@RoshiniNara
Delete avro_testdata.json
b8695dc
@RoshiniNara
Delete avro_testdata.json
d0fbc26 
Deleted unwanted avro test data.json
@KristianLyng KristianLyng merged commit 4b0391c into telenornms:primary Aug 23, 2022
This was referenced Aug 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklirg sklirg sklirg left review comments

@KristianLyng KristianLyng KristianLyng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GOB parser and encoder
4 participants
@RoshiniNara @KristianLyng @sklirg @vnragavan