Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Explorer Vote Page Total Votes Calculation Needs a Fix #838

Open
4 tasks
pmjanus opened this issue Mar 25, 2024 · 0 comments
Open
4 tasks

Block Explorer Vote Page Total Votes Calculation Needs a Fix #838

pmjanus opened this issue Mar 25, 2024 · 0 comments
Labels
🐛 Bug Something isn't working

Comments

@pmjanus
Copy link
Contributor

pmjanus commented Mar 25, 2024

Update Total Votes Calculation on Block Explorer Vote Page to Reflect Voting Power

Description

The current implementation of the vote page on the Block Explorer is displaying the total votes incorrectly. Instead of showing the actual voting power, which is what matters for the election, it's displaying the raw vote count. This discrepancy can lead to misunderstanding of the actual influence each voter has in the election process.
This issue aims to improve the accuracy and clarity of the voting information displayed in the Block Explorer, providing users with a more accurate representation of the election process.

Current Behavior

  • The total votes shown on the vote page represent the raw number of votes cast.
  • This doesn't accurately reflect the voting power of each voter, as it doesn't account for the increased power when voting for multiple Block Producers.

Expected Behavior

  • The total votes displayed should represent the actual voting power.
  • The calculation should take into account the increase in voting power when a user votes for multiple Block Producers.

Technical Details

  • The voting power increases when a user votes for more Block Producers.
  • The exact formula for calculating voting power needs to be confirmed with the blockchain development team to ensure it matches the consensus rules.

Acceptance Criteria

  1. The total votes displayed on the vote page accurately reflects the voting power, not the raw vote count.
  2. The calculation method used matches the blockchain consensus rules for determining voting power.
  3. The UI clearly indicates that the number shown represents voting power, not raw votes.
  4. A tooltip or info icon is added to explain the concept of voting power vs. raw votes.
  5. The change is consistently applied across all relevant pages and components in the Block Explorer.
  6. Unit tests are updated or added to verify the correct calculation of voting power.

Additional Tasks

  • Consult with the blockchain team @poplexity / @jbuice to confirm the exact formula for calculating voting power.
  • Update the backend API if necessary to provide the correct voting power data.
  • Update frontend components to use and display the new voting power data.
  • Add or update documentation to explain the voting power concept to users.
@rozzaswap rozzaswap added the 🐛 Bug Something isn't working label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants