Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : Fix connecting to Teloscan to metamask for the first time uses the old rpc #909

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

zkjamesfish
Copy link

@zkjamesfish zkjamesfish commented Dec 12, 2024

Fixes #890

Description

This PR fixes the issue that let users connect to old RPC when connecting to Metamask for the first time.
I added the new RPC from https://docs.telos.net/build/network-info/.
Mainnet : https://rpc.telos.net
Testnet : https://testnet.rpc.telos.net

Test scenarios

I opened this project in a brand new Google Chrome window and clicked on "Connect Wallet" to let it add the new RPC
I checked my account balance using the new RPC.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • [x ] I have removed any unnecessary console messages
  • [ x] I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

dependabot bot and others added 12 commits August 30, 2024 17:50
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.2 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.88.2...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Dev to Master - Early transactions
…and_yarn/webpack-5.94.0

Bump webpack from 5.88.2 to 5.94.0
…and_yarn/micromatch-4.0.8

Bump micromatch from 4.0.5 to 4.0.8
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…and_yarn/http-proxy-middleware-2.0.7

Bump http-proxy-middleware from 2.0.6 to 2.0.7
Improve Address Page Display and Contract Manager Optimization
Release - Rename Antelope to Core and Add Network Redirection Handling
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 7ab2d94
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/675ac8761309f70008611181
😎 Deploy Preview https://deploy-preview-909--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for teloscan ready!

Name Link
🔨 Latest commit 7ab2d94
🔍 Latest deploy log https://app.netlify.com/sites/teloscan/deploys/675ac876d5c9d30007a87859
😎 Deploy Preview https://deploy-preview-909--teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zkjamesfish zkjamesfish marked this pull request as ready for review December 12, 2024 12:42
@pmjanus pmjanus requested a review from Viterbo December 16, 2024 00:41
@Viterbo Viterbo changed the base branch from master to dev December 16, 2024 17:09
@pmjanus
Copy link
Contributor

pmjanus commented Dec 16, 2024

Thank you sir, we just changed the PR to point to our dev branch, will test and deploy.

@pmjanus pmjanus self-requested a review December 16, 2024 17:11
@pmjanus pmjanus self-requested a review December 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug | Connecting to Teloscan to metamask for the first time uses the old rpc
3 participants