-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Autodiscovery as its own package #854
Comments
@Wulfheart I haven't moved around any namespaces yet, but what are your thoughts on the implementation in #815? |
@aidan-casey I don't really see how the two PRs relate. Yours is about performance. Agreed, you also made some structural changes, but @Wulfheart 's proposal seems simpler and also makes sense. Here are my thoughts:
|
As a followup:
I wonder if it makes sense to have a "default strategy" included in |
Description
Some days ago I saw a thread about it one the project's discord but unfortunately I am unable to find it again.
I really like the Autodiscovery feature and I would like to use this specific component in non-tempest projects. Therefore, I am proposing the following:
Tempest\Core\{DiscoversPath,Discovery,DiscoveryException,DiscoveryItems,DicoveryLocation,IsDiscovery,DoNotDiscover}
toTempest\Discovery
Tempest\Core\{DiscoveryCache,DiscoveryCachingStrategyChangedException,et al.}
stay in core as they are tied to the Tempest specific implementationTempest\Core\Kernel\LoadDiscoveryClasses
will also remain where it is right now as users of theDiscovery
package will have to provide their own strategy on how to load.tempest/discovery
will have a dependency ontempest/reflection
. As far as I can see this should be enough.Benefits
I really enjoy the autodiscovery component and would love to use it in projects outside of tempest. I can also provide a PR if you are not opposed to it.
The text was updated successfully, but these errors were encountered: