diff --git a/Directory.Build.props b/Directory.Build.props index 3c0dd42..67de6eb 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -17,7 +17,7 @@ - 1.2.0 + 1.3.0 - 1.2.0 + 1.3.0 diff --git a/README.md b/README.md index fc049a4..dcd2629 100644 --- a/README.md +++ b/README.md @@ -706,6 +706,8 @@ with .NET tasks inside of workflows: * Use `Workflow.WhenAllAsync` instead. * Technically `Task.WhenAll` is currently deterministic in .NET and safe, but it is better to use the wrapper to be sure. +* Do not use `CancellationTokenSource.CancelAsync`. + * Use `CancellationTokenSource.Cancel` instead. * Do not use `System.Threading.Semaphore` or `System.Threading.SemaphoreSlim` or `System.Threading.Mutex`. * Use `Temporalio.Workflows.Semaphore` or `Temporalio.Workflows.Mutex` instead. * _Technically_ `SemaphoreSlim` does work if only the async form of `WaitAsync` is used without no timeouts and diff --git a/src/Temporalio/Bridge/sdk-core b/src/Temporalio/Bridge/sdk-core index 4619724..631b40a 160000 --- a/src/Temporalio/Bridge/sdk-core +++ b/src/Temporalio/Bridge/sdk-core @@ -1 +1 @@ -Subproject commit 4619724b3e906173edf4e4d77e38e01d39911015 +Subproject commit 631b40a68ef9961abcc9a1bb23d9763a06f6a8f5 diff --git a/src/Temporalio/Client/RpcOptions.cs b/src/Temporalio/Client/RpcOptions.cs index d9bd680..e520440 100644 --- a/src/Temporalio/Client/RpcOptions.cs +++ b/src/Temporalio/Client/RpcOptions.cs @@ -27,7 +27,8 @@ public class RpcOptions : ICloneable public IReadOnlyCollection>? Metadata { get; set; } /// - /// Gets or sets the timeout for the call. Default is no timeout. + /// Gets or sets the timeout for the call. Default timeout is specific to the call (for + /// normal calls this may be 30s, for long-poll calls it is longer). /// public TimeSpan? Timeout { get; set; }