Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Do not warn on unfinished handler on workflow failure #325

Closed
cretz opened this issue Aug 7, 2024 · 0 comments · Fixed by #329
Closed

[Feature Request] Do not warn on unfinished handler on workflow failure #325

cretz opened this issue Aug 7, 2024 · 0 comments · Fixed by #329
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 7, 2024

Describe the solution you'd like

In #294 we warn on any unfinished handler. But we need to not warn on failed workflow (not to be confused with cancelled or continued-as-new which we do want to continue to warn on).
@cretz cretz added the enhancement New feature or request label Aug 7, 2024
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Aug 9, 2024
@cretz
Do not warn about leftover handlers on workflow failure
4b57890 
Fixes temporalio#325
@cretz cretz mentioned this issue Aug 9, 2024
Merged
cretz added a commit that referenced this issue Aug 9, 2024
@cretz
Do not warn about leftover handlers on workflow failure (#329)
efdb9a0 
Fixes #325
@cretz cretz closed this as completed in #329 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not warn about leftover handlers on workflow failure cretz/temporal-sdk-dotnet
1 participant
@cretz