Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/promise v3 doesn't work fine #357

Open
roxblnfk opened this issue Oct 3, 2023 · 0 comments
Open

react/promise v3 doesn't work fine #357

roxblnfk opened this issue Oct 3, 2023 · 0 comments
Labels
Bug Something isn't working
Milestone

Comments

@roxblnfk
Copy link
Collaborator

roxblnfk commented Oct 3, 2023

In order to ensure asynchronous operation of user workflows, coroutines are implemented in the SDK, which use promises. It is a standard situation when we reject them with internal exceptions, which in some branches may not be handled.
However, in the paradigm of react/promise v3, this is considered undesirable practice. Therefore, when a rejected promise is completed, in which there is no exception handler, the error_log() function is called with the error text.

The side effects of such behavior are unpredictable, and it is currently impossible to disable it.

The issue about unhandled exceptions may be fixed once react/promise has the ability to set a permanent handler, not a one-time one.


Thanks to the tests in roadrunner-temporal, other deviations from the normal operation of the SDK were detected. These tests have been partially transferred to the SDK (see #359).

Therefore, I suggest temporarily abandoning react/promise in version 2.6.1 until an solution is found.

@roxblnfk roxblnfk added the Bug Something isn't working label Oct 3, 2023
@roxblnfk roxblnfk added this to the 2.6.0 milestone Oct 3, 2023
@roxblnfk roxblnfk changed the title Unhandled Exceptions in Promises with react/promise v3 react/promise v3 doesn't work fine Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant