Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support registering search attributes as an option/config #6475

Open
cretz opened this issue Sep 3, 2024 · 0 comments
Open

Support registering search attributes as an option/config #6475

cretz opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Sep 3, 2024

Describe the solution you'd like

In CLI we foolishly used operator service to register search attributes immediately after start, but users just check whether port is available to see if started and therefore it may race against operator service.

What we'd like is the ability to set search attributes. Basically something like go.temporal.io/server/temporal.WithSearchAttributes that accepts a map[string]enums.IndexedValueType (or any other structure) and does not start the server until those are confirmed set with that value type. I think the best way is to register if attr name not there, do nothing if attr name there and the proper type, and fail startup if attr there but wrong type. It's possible this can be used for general server config too.

@cretz cretz added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant