From bfbf974bf4ac254ef92bfbd8066b2d92374c9337 Mon Sep 17 00:00:00 2001 From: Tiago Quelhas Date: Tue, 5 Mar 2024 11:38:52 -0800 Subject: [PATCH] Output to bazel-bin instead of bazel-genfiles. In the long term, all uses of bazel-genfiles will be replaced with bazel-bin. Starlark rules should only set `output_to_genfiles = True` when required for compatibility with other rules or tools that make assumptions about the location of output files. Note that Bazel already defaults to `--incompatible_merge_genfiles_directory`, which makes the distinction moot anyway. PiperOrigin-RevId: 612915158 --- third_party/flatbuffers/build_defs.bzl | 2 -- 1 file changed, 2 deletions(-) diff --git a/third_party/flatbuffers/build_defs.bzl b/third_party/flatbuffers/build_defs.bzl index b141ed6a1..c34540666 100644 --- a/third_party/flatbuffers/build_defs.bzl +++ b/third_party/flatbuffers/build_defs.bzl @@ -364,7 +364,6 @@ _gen_flatbuffer_srcs = rule( cfg = "exec", ), }, - output_to_genfiles = True, ) def flatbuffer_py_strip_prefix_srcs(name, srcs = [], strip_prefix = ""): @@ -407,7 +406,6 @@ _concat_flatbuffer_py_srcs = rule( attrs = { "deps": attr.label_list(mandatory = True), }, - output_to_genfiles = True, outputs = {"out": "%{name}.py"}, )