Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include yaml linting and automatic corrections #11034

Open
ttmchiou opened this issue Aug 1, 2024 · 3 comments · May be fixed by #11037
Open

Include yaml linting and automatic corrections #11034

ttmchiou opened this issue Aug 1, 2024 · 3 comments · May be fixed by #11037
Assignees
Labels
feature-request External feature request P2

Comments

@ttmchiou
Copy link
Contributor

ttmchiou commented Aug 1, 2024

Add yamllint and yamlfmt

yamllint serves only for linting yaml and highlighting errors but does not correct
yamlfmt only works on yaml files

https://github.com/jumanjihouse/pre-commit-hook-yamlfmt

@ttmchiou ttmchiou added the feature-request External feature request label Aug 1, 2024
@ttmchiou
Copy link
Contributor Author

ttmchiou commented Aug 1, 2024

@tt-rkim

@ttmchiou ttmchiou self-assigned this Aug 2, 2024
@ttmchiou ttmchiou added the P2 label Aug 2, 2024
@ttmchiou ttmchiou linked a pull request Aug 2, 2024 that will close this issue
3 tasks
@ttmchiou ttmchiou linked a pull request Aug 2, 2024 that will close this issue
3 tasks
ttmchiou added a commit that referenced this issue Aug 7, 2024
ttmchiou added a commit that referenced this issue Aug 7, 2024
ttmchiou added a commit that referenced this issue Aug 7, 2024
@ttmchiou
Copy link
Contributor Author

ttmchiou commented Aug 8, 2024

update here:
yamllint only lints and does not format.
yamlfmt does not use yamllint as a backend so these two are not necessarily compatible after playing around with it a bit.

will try with prettier (which has yaml support) and automatic formatting.

@blozano-tt
Copy link
Contributor

@ttmchiou is this done?

We have yaml-check and yaml-lint in pre-commit ... run on every commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request External feature request P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants