Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Unary Backward ops #12721

Closed
5 tasks done
VirdhatchaniKN opened this issue Sep 16, 2024 · 1 comment
Closed
5 tasks done

Cleanup Unary Backward ops #12721

VirdhatchaniKN opened this issue Sep 16, 2024 · 1 comment
Assignees
@VirdhatchaniKN
Labels
MCW ttnn

Comments

@VirdhatchaniKN
Copy link
Contributor

VirdhatchaniKN commented Sep 16, 2024 •
edited
Loading

Task :

  • Remove ttnn/cpp/ttnn/operations/eltwise/unary_backward/device/unary_backward_op.hpp
  • Delete ttnn/cpp/ttnn/operations/eltwise/unary_backward/device
  • Move ttnn/cpp/ttnn/operations/eltwise/unary_backward/device/unary_backward_op.cpp to ttnn/cpp/ttnn/operations/eltwise/unary_backward/unary_backward.cpp

Status : In Progress
In #10543, All of the overloaded comparison ops has been removed . It was found that 5 comparison ops (except for LT_BW) is required. Support for those ops have to be included as two comparison ops are defined in the unary_backward_op.hpp file.So, Working on that.

Issues :
@VirdhatchaniKN VirdhatchaniKN self-assigned this Sep 16, 2024
@VirdhatchaniKN VirdhatchaniKN changed the title Cleanup 3 Unary Backward ops Cleanup 16 Unary Backward ops Sep 17, 2024
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Sep 17, 2024
Closed
@VirdhatchaniKN VirdhatchaniKN changed the title Cleanup 16 Unary Backward ops Cleanup Unary Backward ops Sep 17, 2024
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Sep 18, 2024
Closed
4 tasks
This was referenced Sep 19, 2024
Closed
Closed
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Sep 23, 2024
Closed
4 tasks
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Sep 25, 2024
Closed
4 tasks
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup set-3 Unary Backward ops
32c701f
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Sep 27, 2024
Merged
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup sinh_bw, log10_bw
299451d
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup sinh_bw, log10_bw (#13208)
857293e
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup sinh_bw, log10_bw
5b5cced
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: asinh_bw, sin_bw
6ec58d3
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: asinh_bw, sin_bw (#13210)
83a4153
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup asinh_bw, sin_bw
6546053
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup atanh_bw, asin_bw
11c1d24
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup 4 ops
4ae11b8
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup set-3 Unary Backward ops
c68ea94
VirdhatchaniKN added a commit that referenced this issue Sep 27, 2024
@VirdhatchaniKN
#12721: Cleanup set-3 Unary Backward ops
b9b7ae9
VirdhatchaniKN added a commit that referenced this issue Sep 28, 2024
@VirdhatchaniKN
#12721: Cleanup set-3 Unary Backward ops
245cc55
VirdhatchaniKN added a commit that referenced this issue Sep 28, 2024
@VirdhatchaniKN
#12721: Cleanup set-3 Unary Backward ops (#13207)
bda4f02
@VirdhatchaniKN
Copy link
Contributor Author

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VirdhatchaniKN VirdhatchaniKN

Labels
MCW ttnn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VirdhatchaniKN