Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttnn.split should support incomplete splits #12859

Open
jaykru-tt opened this issue Sep 19, 2024 · 1 comment
Open

ttnn.split should support incomplete splits #12859

jaykru-tt opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working ttnn

Comments

@jaykru-tt
Copy link
Contributor

ttnn.split (analogous to torch.chunk) currently doesn't have support for incomplete splits (splits for which the number of elements in the dimension on which we split is not divisible by num_splits). For RM tensors, adding support for this may be as simple as ensuring that slice handles slices similarly to torch.slice and removing the TT_FATAL at the beginning of the split op checking for divisibility of shape[dim] by num_splits.

@jaykru-tt jaykru-tt added the bug Something isn't working label Sep 19, 2024
@jaykru-tt jaykru-tt self-assigned this Sep 19, 2024
@jaykru-tt
Copy link
Contributor Author

While we're at it, we should rename ttnn.split to ttnn.chunk for consistency with torch.

@jaykru-tt jaykru-tt added the ttnn label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ttnn
Projects
None yet
Development

No branches or pull requests

1 participant