Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal 1.0: kernel base file includes headers visible to user code #12975

Open
pgkeller opened this issue Sep 21, 2024 · 0 comments
Open

metal 1.0: kernel base file includes headers visible to user code #12975

pgkeller opened this issue Sep 21, 2024 · 0 comments

Comments

@pgkeller
Copy link
Contributor

This is a build problem and an API problem, may need to split in two.

Kernel builds build a wrapper, eg, brisck.cc to launch the user supplied kernel.
Internally, I believe the user supplied kernel gets catenated w/ the wrapper.
This means header files included in the wrapper get included in the client kernel by default.
For example, removing dataflow_api.h in idle_erisck.cc results in user kernel build failures.
The wrapper headers should be cleaned up/reduced, but this dependency causes grief, so better to break the dependency and clean up later. This means fixing the build first.

fyi: @eyonland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant