Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to execute model from explorer #1020

Closed
odjuricicTT opened this issue Oct 23, 2024 · 4 comments
Closed

Add option to execute model from explorer #1020

odjuricicTT opened this issue Oct 23, 2024 · 4 comments
Assignees
Labels
explorer Issues related to Explorer Visualization tool

Comments

@odjuricicTT
Copy link
Contributor

This might require changes in ttrt in order to be able to use ttrt.API.perf.

@odjuricicTT
Copy link
Contributor Author

odjuricicTT commented Oct 23, 2024

@vprajapati-tt What do you think about adding --output-file (or similar) to ttrt perf, in other to not have to parse the output of a subprocess?

@vprajapati-tt
Copy link
Contributor

Hey! I just saw this, a while back I added the --artifact-dir option when running perf. TTRT itself outputs the log to a file (if specified) and also stdin. The issue with Perf is that TTRT ends up using signal to look for SIGINT and SIGTERM from Tracy. Since model-explorer is run in a thread (or process), this isn't well received by python and it either crashes or doesn't detect these signals. I played around with this for a while and circled back to using a subprocess since that was the simplest method to get a prototype working.

I'd be interested to revisit this as there's probably something I'm missing that can solve this problem. Let me know if there's anything else I can clarify.

@vprajapati-tt vprajapati-tt added the explorer Issues related to Explorer Visualization tool label Oct 23, 2024
@odjuricicTT
Copy link
Contributor Author

Got it! Thanks for the info, we'll take a look if there is a good way to solve this. If not we will stick with a subprocess then.

@odjuricicTT odjuricicTT self-assigned this Nov 6, 2024
@odjuricicTT
Copy link
Contributor Author

Completed via #1210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Issues related to Explorer Visualization tool
Projects
None yet
Development

No branches or pull requests

2 participants