Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of custom functions for the scatter op in TTNN dialect. #1278

Open
ajakovljevicTT opened this issue Nov 15, 2024 · 0 comments
Open
Labels
stablehlo conversion bug Bugs in StableHLO conversion

Comments

@ajakovljevicTT
Copy link
Contributor

During lowering of the stablehlo.scatter op, there was an issue with lowering the full functionality of the op, since the StableHLO version also accepts a function which denotes an operation used in combining both the target at scattered tensor. Currently, this is not used in any model that we have tried on. However, there is a jax operation scatter_add where this function is a simple add, suggesting the need for it (see: https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.scatter_add.html). It is possible to decompose this and leave the intricacies of this function out of tt-metal, since it does not currently support this, nor indexing in scatter (issue in metal: tenstorrent/tt-metal#4294).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stablehlo conversion bug Bugs in StableHLO conversion
Projects
None yet
Development

No branches or pull requests

1 participant