Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate arch specific code to directories #56

Open
pjanevskiTT opened this issue Sep 10, 2024 · 1 comment
Open

Separate arch specific code to directories #56

pjanevskiTT opened this issue Sep 10, 2024 · 1 comment
Labels
enhancement New feature or request P2 Minor issues repo health Code design, code readability, linting, file restructuring, etc.

Comments

@pjanevskiTT
Copy link
Contributor

pjanevskiTT commented Sep 10, 2024

Separate arch specific code into separate directories. This way we achieve two things

For example, for something like https://github.com/tenstorrent/tt-umd/blob/main/device/driver_atomics.h, we should have something like

arch
|----- x86
|       |------ driver_atomics.hpp
|
|----- arm
|       |------ driver_atomics.hpp

Maybe driver atomics file is not the right granularity to do this, maybe we need to do it in smaller/bigger chunks, but that should be investigated through this issue as well.

@pjanevskiTT pjanevskiTT added good first issue Good for newcomers repo health Code design, code readability, linting, file restructuring, etc. enhancement New feature or request and removed good first issue Good for newcomers labels Sep 10, 2024
@pjanevskiTT pjanevskiTT self-assigned this Sep 23, 2024
@pjanevskiTT pjanevskiTT added the P2 Minor issues label Nov 5, 2024
@pjanevskiTT
Copy link
Contributor Author

We already had one PR closed on this because it adds complexity, I won't close this because it would be good to have this sometime in the future, but it is really low prirority at the moment

@pjanevskiTT pjanevskiTT removed their assignment Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Minor issues repo health Code design, code readability, linting, file restructuring, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant