Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema issues #1315

Open
jsnoble opened this issue Dec 5, 2024 · 0 comments
Open

schema issues #1315

jsnoble opened this issue Dec 5, 2024 · 0 comments

Comments

@jsnoble
Copy link
Member

jsnoble commented Dec 5, 2024

The schema used for validation has many elasticsearch client parameters, which is fine if no api_name is listed. The schema's validateJob call also calls the ensureAPIFromConfig base method and splits it off to an api and copies its configs there for the api to use. However if an api is preconfigured and attributed to an operation, that operation should no longer have connection parameters

We do check if the configs are out of sync and throw if so, however an operation will still throw if the base schema says it requires a connection parameter even though it properly lives in its api configuration. We should investigate if its possible to allow that kind of smart checking to reduce noise and duplication of configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant