Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize merging common_processors into Standard-assets #924

Open
ciorg opened this issue Oct 16, 2024 · 2 comments
Open

Finalize merging common_processors into Standard-assets #924

ciorg opened this issue Oct 16, 2024 · 2 comments

Comments

@ciorg
Copy link
Member

ciorg commented Oct 16, 2024

We've had a slow ongoing process of moving the processors in common_processors (an internal asset) to standard-assets. There are only a few left that would still be useful to move to standard assets.

* update
* date_guard
* count_unique
* copy_id
* filter_by_required_fields
* add_short_id
* dropdoc
* json_parse
@jsnoble
Copy link
Member

jsnoble commented Oct 22, 2024

additional processors:

  • filter
  • filter_by_unknown_fields
  • remove_empty_fields
  • set_field_conditional

@ciorg
Copy link
Member Author

ciorg commented Oct 24, 2024

After meeting today I was reminded that dropdoc should be renamed to sample or something along those lines. Right now it's easy to get confused because when you increase the dropdoc value you get less data, if it was sample then the percentage value would be the percent of records being kept and passed through.

Also, update is a poor name for the processor - it updates some fields and uses caching to reduce the strain of having es update the fields. But it should have a name that better represents what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants