Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teraslice-messaging, teraslice] Add abortController for use with sendSliceComplete() #3838

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Nov 20, 2024

This PR makes the following changes:

  • The execution-controller Client now creates an abortController. Every call to Client.sendSliceComplete() now includes a reference to abortController.signal allowing for the pEvent in the messenger Core.onceWithTimeout() to be aborted.
  • A new listener is added for the server:shutdown event that calls abortController.abort(). This prevents a worker from still waiting for a response to sendSliceComplete() after the server is shutdown.
  • bump teraslice-messaging from 1.7.0 to 1.7.1

ref: #2106

@busma13 busma13 changed the title Add abort controller for use with sendSliceComplete [teraslice-messaging] Add abort controller for use with sendSliceComplete() Nov 20, 2024
@busma13 busma13 changed the title [teraslice-messaging] Add abort controller for use with sendSliceComplete() [teraslice-messaging] Add abortController for use with sendSliceComplete() Nov 20, 2024
@busma13 busma13 marked this pull request as ready for review November 20, 2024 21:07
@busma13 busma13 changed the title [teraslice-messaging] Add abortController for use with sendSliceComplete() [teraslice-messaging, teraslice] Add abortController for use with sendSliceComplete() Nov 21, 2024
@busma13 busma13 requested a review from godber November 21, 2024 18:36
@busma13 busma13 added this to the Teraslice 2.8.0 milestone Nov 21, 2024
@godber godber removed this from the Teraslice 2.8.0 milestone Nov 22, 2024
@godber godber merged commit 7690ba1 into master Nov 22, 2024
48 checks passed
@godber godber deleted the long-shutdown-fix branch November 22, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants