-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to run coverage
on python 3.11
#1377
Comments
Well, that's a bit of a shame. ARMI currently uses To be honest, I don't love |
Open issue with coverage_lcov being incompatible with coverage 7.0.0 is here FWIW, running Looks like pytest can output directly to lcov format though so we can skip the lcov conversion:
ref: https://github.com/epitools/epitools/pull/72/files I tried running a modified version of our tox test line:
and sure enough |
coveragepy-lcov is incompatible with coverage 7.0.0 and in fact is totally unnecessary now that pytest can write lcov format files directly. This switches pytest to write lcov directly. Now coverage should work in CI on python 3.11 Fixes #1377
* Remove coveragepy-lcov dependency during CI. coveragepy-lcov is incompatible with coverage 7.0.0 and in fact is totally unnecessary now that pytest can write lcov format files directly. This switches pytest to write lcov directly. Now coverage should work in CI on python 3.11 Fixes #1377 * Remove coverage pins and change coverage to py311. Requested in review.
Typically, github actions are set to run on the latest version of python that we have tested with ARMI. #1341 originally set out to bring all GH actions up to python 3.11, but a known issue with
coverage
(#1058) prevented us from updating the coverage dependency to a python 3.11 compatible version.We need to investigate the bug with the coverage version and see if it can be fixed.
I had coverage pinned to 7.2.1 in both setup.py and the coverage workflow, and the action failed.
Update: I'm not sure what the above bug is all about, but
coveragepy_lcov
has not been updated in 1.5 years and is not python 3.11 compatible. So we will need to completely rework the cooverage step to make it run on python 3.11The text was updated successfully, but these errors were encountered: