-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary spec for dummy block #1453
Labels
cleanup
Code/comment cleanup: Low Priority
Comments
I really hope the dummy block is never used. But, great! Can't wait! |
@albeanth - what's the progress on this and other axial expansion improvements? |
|
Grabbing this because I'm already mucking around with some axial expansion related things and this seems like good thing to grab as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
armi/armi/reactor/converters/axialExpansionChanger.py
Lines 752 to 753 in 753660d
The axial expansion target component for the dummy block is never used. We don't need to enforce that a coolant component be the axial expansion target component for the dummy block.
_setTargetComponent
can also just loop over the non-dummy blocks.The text was updated successfully, but these errors were encountered: