Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary spec for dummy block #1453

Closed
albeanth opened this issue Oct 30, 2023 · 4 comments · Fixed by #1920
Closed

Remove unnecessary spec for dummy block #1453

albeanth opened this issue Oct 30, 2023 · 4 comments · Fixed by #1920
Assignees
Labels
cleanup Code/comment cleanup: Low Priority

Comments

@albeanth
Copy link
Member

elif b.hasFlags(Flags.DUMMY):
self.determineTargetComponent(b, Flags.COOLANT)

The axial expansion target component for the dummy block is never used. We don't need to enforce that a coolant component be the axial expansion target component for the dummy block. _setTargetComponent can also just loop over the non-dummy blocks.

@albeanth albeanth added the cleanup Code/comment cleanup: Low Priority label Oct 30, 2023
@albeanth albeanth self-assigned this Oct 30, 2023
@john-science
Copy link
Member

I really hope the dummy block is never used.

But, great! Can't wait!

@jakehader
Copy link
Member

@albeanth - what's the progress on this and other axial expansion improvements?

@albeanth
Copy link
Member Author

albeanth commented Jul 5, 2024

@albeanth - what's the progress on this and other axial expansion improvements?

  • this specifically? Nothing. But it should be as simple as deleting those two lines and maybe updating/adding a test.
  • there will be a large refactor of axialExpansionChanger.py soon. Refactor Axial Expansion #1435 has been blocked by downstream updates but is now unblocked and is in line to go through.
  • Add New Component Axial Linking Approach #1376 is planned to go through sometime between now and October.
  • I have a new feature branch for axial expansion documentation... Someday that will go through... The scope of it is quite large
    so that is going to take time (time I don't really have right now, tbh ☹️ ). main...albeanth:armi:axial_exp_documentation_finally

@drewj-tp
Copy link
Contributor

Grabbing this because I'm already mucking around with some axial expansion related things and this seems like good thing to grab as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants