Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more memory-use printouts #1823

Open
opotowsky opened this issue Aug 14, 2024 · 4 comments
Open

Add more memory-use printouts #1823

opotowsky opened this issue Aug 14, 2024 · 4 comments
Labels
feature request Smaller user request

Comments

@opotowsky
Copy link
Member

opotowsky commented Aug 14, 2024

Add some memory-use print-outs to extra or debug levels.

This would help with memory profiling for some upcoming work.

Alternatively, take a look at memory profiling and add more printouts to that.

@john-science john-science added the feature request Smaller user request label Aug 14, 2024
@john-science john-science changed the title add more memory use printouts to extra verbosity level Add more memory-use printouts Aug 26, 2024
@john-science
Copy link
Member

Have you used ARMI's MemoryProfiler?

class MemoryProfiler(interfaces.Interface):

One thing I note, that tool (and your above idea) both require the dependency psutil. And that is a pretty squiffy dependency I don't want to have to import/install by default.

@albeanth
Copy link
Member

the start of something
main...newMemoryInfo

@opotowsky
Copy link
Member Author

Have you used ARMI's MemoryProfiler?

class MemoryProfiler(interfaces.Interface):

One thing I note, that tool (and your above idea) both require the dependency psutil. And that is a pretty squiffy dependency I don't want to have to import/install by default.

MemoryProfiler itself uses psutil. Tony's branch is I think just adding to that class. So all should be well, but let's double check on PR review that we aren't adding any unprotected psutil imports here!

@john-science
Copy link
Member

Okay, if your goal is just to improve the MemoryProfiler class, I'm thrilled. Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

No branches or pull requests

3 participants