Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMI should not forcibly add a SFP to the Reactor #1871

Open
john-science opened this issue Sep 12, 2024 · 0 comments
Open

ARMI should not forcibly add a SFP to the Reactor #1871

john-science opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
architecture Issues related to big picture system architecture

Comments

@john-science
Copy link
Member

Right now, ARMI forcibly adds a Spent Fuel Pool (SFP) to every Reactor object:

if not any(structure.typ == "sfp" for structure in bp.systemDesigns.values()):
bp.addDefaultSFP()

I think this is rather a lazy idea and default, meant to temporarily help out a small number of users downstream who had blueprints that didn't have SFPs in them.

I think it's time to pull the Band-Aid™ off, and make people define their own SFP in the blueprints.

And, not for nothing, I just hate the default values that are in our default SFP:

def addDefaultSFP(self):

self.spatialGrid = grids.CartesianGrid.fromRectangle(50.0, 50.0)
self._filler = RowMajorAutoFiller(self, 10)

@john-science john-science added the architecture Issues related to big picture system architecture label Sep 12, 2024
@john-science john-science self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture
Projects
None yet
Development

No branches or pull requests

1 participant