Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HexBlock.getFlowArea() calculation #1988

Open
john-science opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1995
Open

Improve HexBlock.getFlowArea() calculation #1988

john-science opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1995
Assignees
Labels
enhancement New feature or request

Comments

@john-science
Copy link
Member

Right now, the HexBlock.getFlowArea() calculation only calculates the area based on Flags.COOLANT, but @clstocking reports it could also be dependent on Flags.INTERDUCTCOOLANT.

From the current calc:

return self.getComponent(Flags.COOLANT, exact=True).getArea()

To something more like:

area = self.getComponent(Flags.COOLANT, exact=True).getArea()
for c in self.getComponents(Flags.INTERDUCTCOOLANT, exact=True):
    area += c.getArea()

return area
@john-science john-science added the enhancement New feature or request label Oct 30, 2024
@john-science john-science self-assigned this Oct 31, 2024
@john-science john-science linked a pull request Oct 31, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant