Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some legacy things? #151

Open
jimmywarting opened this issue Apr 7, 2023 · 2 comments
Open

Remove some legacy things? #151

jimmywarting opened this issue Apr 7, 2023 · 2 comments

Comments

@jimmywarting
Copy link

Flash and older ie is pretty much dead now...
So i was wondering if things such as applet, object and conditional comments such as Conditional ie Comment could be removed now.

case 'object':
if (hasAttrName('data', attrs)) {
return false;
}
break;
case 'applet':
if (hasAttrName('code', attrs)) {
return false;
}
break;

@sibiraj-s
Copy link
Collaborator

Sounds okay to me. but it calls for a new major.

Also, Sometimes I think of re-writing the package with htmlparser2 and make it more modern. but it replicating them is not as easy as it seems. dropping some old and redundant features might enable that in coming days may be

@markjaquith
Copy link

Please don't remove conditional comments. For better or worse, they're part of the HTML landscape, and stripping them out will break things. People write them for purposes other than IE, and expect them to be present in the HTML output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants