-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hangs after receiving charging-set-amps CMD when car is not home #67
Comments
Useful information thanks. According to comments in the code it might be possible to get stuck like this. I'm currently working on a new release which will add reading of state functionality. I might not get time for a while to look at this issue. @baylanger Pierre do you have time to look at it? Why it happens on your new car not your old is a mystery. |
Might very well be my own mistake. When switching cars I also reconfigured a lot in Home Assistant. Might (even likely when I think about it) be that this scenario (sending charging-set-amps when not home) never occurred before. I'll work around by fixing "my" bug in HA. Just wanted you to know so you can make your server resilient to this scenario. |
@iainbullock could you implement the "failsafe" mode with reading the stdout of teslaCtrlSendCommand? |
Raphael What's the failsafe mode sorry? You can definately cause the system to hang by continuing to send commands if the car is away as the timeouts are long and repeat several times, there is soon a massive backlog of commands which I believe eventually causes a crash or the bluetooth to hang |
I suggest, in the
|
Ah right I see what you mean. As per my comment in the PR tesla-local-control/tesla_ble_mqtt_core#141 (review) I think we should rewrite this function. You will notice I copied and did a partial re-write to support reading of state see sendBLECommand() function in read-state.sh. More work required and it depends on the success of body-controller-state in actual use. I'd prefer to release now without changing it yet, see what feedback we get, then introduce in a future release. What do you think? |
I have implemented changes in v0.4.3b-dev which is on DockerHub. Main changes are robustness improvements, see the CHANGELOG., also tesla-local-control/tesla_ble_mqtt_core#142 |
I've used the BLE MQTT Docker with a Model 3 since its conception and it's been rock solid. A couple of weeks ago I replaced the Model 3 with a Model Y and since then I have experienced multiple "hangs" of the server.
When it is hanged it does not detect car presence (always OFF) nor reponds to MQTT commands.
After reviewing the logs from a couple of hangs, I believe this is what happens:
Here are my logs for the last time this happened.
The text was updated successfully, but these errors were encountered: