✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	5b772d1
🔍 Latest deploy log	https://app.netlify.com/sites/teslamate/deploys/668e2fbec038b500085de185
😎 Deploy Preview	https://deploy-preview-4069--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Not yet working correctly in our ghcr image, as git command is not available in our docker file

Not yet working correctly in our ghcr image, as git command is not available in our docker file

I would imagine the nix flake build will have the same issue. The git repo stuff not available in the build.

Think we will need to use environment variables, as per #3682 (comment).

For Docker these need to be passed to the docker build command. --build-arg=arg=value

Nix is easier, with something like this would create the environment variables (this needs to be used in appropriate place):

 build_env = {
          BUILD_DATE =
            with flockenzeit.lib.splitSecondsSinceEpoch { } self.lastModified;
            "${F}T${T}${Z}";
          VCS_REF = "${self.rev or "dirty"}";
        };

Although it is unfortunate you need the flockenzeit just to format the date time. This doesn't use the VERSION file, combining the two shouldn't be hard.

Forgot to say:

• Version number should be set at build time. Oh wait, I think we already do this. Good.
• Suggest using environment variables as first preference. If they are not defined, then fall back to something else.

I would imagine the nix flake build will have the same issue. The git repo stuff not available in the build.

Yeah, assume this as well. As we use a two staged docker build, we could add git in the builder step to have the command available with no real downside imo. Will test this. In the end build env are the best choice imo as well.