New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is the "IsBinary" funtion return wrong value? #103

Open

zzb-client opened this issue Jun 19, 2018 · 1 comment

zzb-client commented Jun 19, 2018

in thresholder.h line 75

/// Returns true if the source image is binary.
bool IsBinary() const {
return pix_channels_ == 0;
}

is it should be "return pix_channels_ == 1;" for binary images?

amitdo commented Jun 19, 2018

/// Returns true if the source image is binary.
bool IsBinary() const {
return pix_channels_ == 0;
}

The code is right.

Channel - 8 bit.
Binary - 1 bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment