Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS-Independent CI #834

Closed
marip8 opened this issue Dec 16, 2022 · 6 comments
Closed

ROS-Independent CI #834

marip8 opened this issue Dec 16, 2022 · 6 comments

Comments

@marip8
Copy link
Contributor

marip8 commented Dec 16, 2022

Currently the Linux CI jobs use a custom docker image with ROS1 components installed. This is a bit unnecessary and causes problems for downstream ROS-independent or ROS2 builds that use the docker image generated by tesseract CI (like here). We should update the CI to be independent of ROS as in tesseract-robotics/boost_plugin_loader#12.

@Levi-Armstrong
Copy link
Contributor

What about using colcon but avoid using industrial_ci and ros dependendecies?

@marip8
Copy link
Contributor Author

marip8 commented Dec 28, 2022

Yes, that's what I'm suggesting. That's what we did in the plugin loader library

@marip8
Copy link
Contributor Author

marip8 commented Mar 7, 2023

I recently opened a PR to add this capability to industrial_ci: ros-industrial/industrial_ci#818.

@Levi-Armstrong what do you think about transitioning the builds over to this branch of ICI? It would make the CI builds cleaner and make building downstream CI pipelines for tesseract_ros/2 and other dependent projects easier to do.

@Levi-Armstrong
Copy link
Contributor

I don't have an issue with that. Have you received any feedback on your PR?

@marip8
Copy link
Contributor Author

marip8 commented Mar 8, 2023

Not yet and no comments on the corresponding issue I opened; I'm not sure who to ping for a review

@marip8
Copy link
Contributor Author

marip8 commented Mar 14, 2023

Closing; addressed in #861

@marip8 marip8 closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants