Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty key names accepted #352

Open
HolQue opened this issue Oct 24, 2024 · 3 comments
Open

Empty key names accepted #352

HolQue opened this issue Oct 24, 2024 · 3 comments

Comments

@HolQue
Copy link
Collaborator

HolQue commented Oct 24, 2024

JSON:

"" : "value"

Result:

DotDict({'': 'value'})

Empty strings are accepted as key name. Here I have doubts.

Cross check:

" " : "value"

Result:

Error: 'Invalid key name: " ". Key names have to start with a letter, digit or underscore.'!

That is OK, and in my opinion also an empty string should be an invalid key name.

@test-fullautomation
Copy link
Owner

Yes, empty string as key must cause an error message.

@namsonx namsonx moved this from Open to In Progress in RobotFramework AIO Dec 25, 2024
@namsonx
Copy link
Collaborator

namsonx commented Dec 25, 2024

The fix was pushed to stabi branch
Ready for ROBFW-AIO 0.13.2

@HolQue
Copy link
Collaborator Author

HolQue commented Jan 3, 2025

Retest successful. Issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants