Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testground (node + browser) test to this repo #27

Open
GlenDC opened this issue Nov 12, 2022 · 3 comments
Open

add testground (node + browser) test to this repo #27

GlenDC opened this issue Nov 12, 2022 · 3 comments
Assignees

Comments

@GlenDC
Copy link
Contributor

GlenDC commented Nov 12, 2022

Follow-up task from #26.

Now that sdk-js (this repo) is supposed to work both in the browser and nodeJS alike,
it would be good to have a testground testplan to ensure this continues to work.

@laurentsenta assigned it to me and we can find inspiration for this in the rust-sdk.

@GlenDC
Copy link
Contributor Author

GlenDC commented Nov 13, 2022

@laurentsenta in our next sync we can try to define the kind of tests that would be useful and desired, both for Node and Browser. If we can come up with an initial list of tests I can also start working on this in the background.

@laurentsenta
Copy link
Contributor

@GlenDC that sounds great, thanks for taking over this task.

Some notes here to make sure every contributor has access to the discussion:

We'd get a huge confidence improvement by having "some tests now," the rust SDK suite is a good example here (we caught some bug with just these two tests): https://github.com/testground/sdk-rust/blob/master/examples/example.rs

If we add, on every PR:

  • in node js only (because it requires almost no setup)
  • a simple example that logs a message,
  • a simple publish subscribe that uses the sync service,

That would be a great improvement,

The main problem we'll have to think about with browser tests is that they require a lot of code we'll have to move from the testground repo (maybe git clone the repo, maybe wait for native support in testground, maybe...)

@GlenDC
Copy link
Contributor Author

GlenDC commented Nov 15, 2022

Ok let's for now perhaps already start with just the NodeJS ones. Those plans can than be run in browser once we have official support for the browser.

Shall I start working on native support of browser in testground @laurentsenta ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants