Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting viewport size #11

Open
jecfish opened this issue Aug 21, 2022 · 1 comment
Open

Support setting viewport size #11

jecfish opened this issue Aug 21, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@jecfish
Copy link
Contributor

jecfish commented Aug 21, 2022

The Recorder contains details to set viewport size. This step is not exported.

{
      "type": "setViewport",
      "width": 375,
      "height": 667,
      "deviceScaleFactor": 1,
      "isMobile": false,
      "hasTouch": false,
      "isLandscape": false
    },
@nickserv
Copy link
Member

Answered in DMs, but reposting for historical purposes:

Yea that's intentional. It's because it's currently using JSDOM (the most common environment for Testing Library) which doesn't implement layout.

I plan on looking into this and several of the other unsupported steps once #1 is done so we have the option of running in a real visual browser.

@nickserv nickserv added the enhancement New feature or request label Aug 21, 2022
@nickserv nickserv moved this from Todo to Blocked in Testing Library Recorder Extension Aug 21, 2022
@nickserv nickserv added this to the 2.0.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants