Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessRunners call method throws Exception #29

Open
WaDelma opened this issue Sep 5, 2015 · 2 comments
Open

ProcessRunners call method throws Exception #29

WaDelma opened this issue Sep 5, 2015 · 2 comments

Comments

@WaDelma
Copy link
Contributor

WaDelma commented Sep 5, 2015

It should propably throw all the specific exception that it has to throw.
Encountered to a bug where catching all exceptions ate NullPointerException.

@jamo
Copy link
Member

jamo commented Sep 6, 2015

The signature for Callable#call is V call() throws Exception.
Thus we basically need to catch of throw Exception, even though it's kinda ugly.

However, we should take care to never silently swallow the exceptions, but to always at least log the exception.

@WaDelma
Copy link
Contributor Author

WaDelma commented Sep 6, 2015

Well I tried to change it to specific exception types and it didn't complain about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants