Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remote package from TestNG #12

Closed
juherr opened this issue Jan 1, 2016 · 6 comments
Closed

Remove remote package from TestNG #12

juherr opened this issue Jan 1, 2016 · 6 comments

Comments

@juherr
Copy link
Member

juherr commented Jan 1, 2016

I was thinking about removing the remote package from TestNG, but how can we manage it?

I think TestNG should not have a dependency to testng-remote but, currently, TestNG imports some remote classes (SuiteDispatcher and SuiteSlave).

Do you have an idea?

@cbeust
Copy link
Collaborator

cbeust commented Jan 1, 2016

Shouldn't TestNG simply depend on testng-remote?

@juherr
Copy link
Member Author

juherr commented Jan 1, 2016

I don't know if it will work as testng-remote already depends on testng

@missedone
Copy link
Contributor

i don't think we can do it now since testng-remote depends on testng which will cause circular dependency.
besides with SuiteDispatcher and SuiteSlave, there is also org.testng.xml.ResultContentHandler and org.testng.xml.ResultXMLParser depends on *Message, IRemoteSuiteListener and IRemoteTestListener
i think we need find a way to abstract them.

@missedone
Copy link
Contributor

regards to SuiteDispatcher and SuiteSlave which enables TestNG to be able running in master/slave mode. After some investigation, i'd suggest to remove the master/slave feature out of TestNG, make it into a sub-module of testng-remote or a small project like testng-remote.
the reason is, i found it's hard to define a set of API for SuiteDispatcher and SuiteSlave which does not depends on TestNG and TestNG Remote.
to implement master/slave, since it's a separate module, we can make it depend on TestNG and TestNG Remote, and introduce a new main class DistributedTestNG extends TestNG, if people want to use master/slave mode, they need to use this new main class instead.
in this way, we can make the structure for TestNG / TestNG Remote / TestNG Distributed clean and each one has a clear roles of responsibility.
what do you think @cbeust ?

@missedone
Copy link
Contributor

BTW, Cedric's weblog http://beust.com/weblog2/archives/000362.html can help understand how master/slave works

@juherr
Copy link
Member Author

juherr commented Jan 11, 2016

testng-team/testng#953

@juherr juherr closed this as completed Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants