Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mismatch between mz_uint64 and std::uint64_t #12

Open
Eisenwave opened this issue Jun 4, 2020 · 3 comments · May be fixed by #27
Open

Type mismatch between mz_uint64 and std::uint64_t #12

Eisenwave opened this issue Jun 4, 2020 · 3 comments · May be fixed by #27

Comments

@Eisenwave
Copy link

In line 518, mz_uint64_t is defined as unsigned long long.
However, std::uint64_t on my platform (Linux 64-bit Debian 11) is defined as unsigned long.

This leads to errors on multiple lines.
@SanPen
Copy link

SanPen commented Oct 29, 2022 •
edited
Loading

I confirm the error, and when I correct the type, I get the error multiple definition of almost everything.
Not sure what am I doing wrong there

@samfayad
Copy link

Same thing happens over here on Ubuntu 22.04. Anyone found a solution?

@rpatters1
Copy link

rpatters1 commented Jan 4, 2025 •
edited
Loading

I have the same problem. The fix is probably to define the mz ints as their std:: counterparts, but I have no idea what the risk of doing so is.

@rpatters1 rpatters1 linked a pull request Jan 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use mz_uint64 for internal consistency across all platforms rpatters1/miniz-cpp
4 participants
@samfayad @rpatters1 @SanPen @Eisenwave