Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: deduplication for receivers only setup #7807

Open
lachruzam opened this issue Oct 9, 2024 · 1 comment
Open

Query: deduplication for receivers only setup #7807

lachruzam opened this issue Oct 9, 2024 · 1 comment

Comments

@lachruzam
Copy link
Contributor

Is your proposal related to a problem?

In a deployment based only on receivers (no sidecars or HA Prometheus instances), each replicated timeseries holds the same data or parts of it (for example, when an instance is not available for some period of time).
While Thanos Query uses the penalty deduplication algorithm that fills in missing points only after the penalty window, this situation causes gaps even when the data is available in the other replica.
In such cases, I expect the deduplication algorithm to return all available data points.

Describe the solution you'd like

Allow an option to change the deduplication algorithm by adding a new flag to the query command.
As an alternative algorithm, the standard Prometheus deduplication algorithm could be used.

Additional context

Screenshots present the problem that occurs during receivers restart.
without-dedup
with-dedup

@lachruzam
Copy link
Contributor Author

PR: #7808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant