-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Light mode does not persist on title page after refresh #334
Comments
The issue seems to happen on every layout, part of the layout doesn't take account the localStorage value: |
I am able to reproduce on prod, but not on develop prod steps: light mode -> refresh -> switches to dark mode with black text |
I'm feeling like it's related to statically generated generated Gatsby assets |
yes 100%: https://joshwcomeau.com/gatsby/dark-mode/ improved solution from what we have |
I'll look into it--does it look like a major overhaul? |
No we have the majority of the groundwork already for it, it's mainly injecting some JS at runtime before Gatsby runs which is covered by the article. |
Description:
When light mode is enabled, refreshing the title page will revert it back to dark mode.
To Reproduce:
Expected Behavior:
Light mode to persist after refresh
Environment:
The text was updated successfully, but these errors were encountered: