Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to include the patch? #5

Closed
Eskuero opened this issue Aug 29, 2019 · 2 comments
Closed

How to include the patch? #5

Eskuero opened this issue Aug 29, 2019 · 2 comments

Comments

@Eskuero
Copy link

Eskuero commented Aug 29, 2019

Hello,
would you mind sharing which steps and modifications did you made to Signal-Android repository so it would build using signalapp/libsignal-service-java#70 ?

As of now it will always pull the prebuilt library when building the .apk so no fixes include and I couldn't figure out how to exactly include libsignal-service-java in build.gradle as source.

Thanks in advance!

@theBoatman
Copy link
Owner

First you need to build the library locally with:

gradlew.bat tasks installArchives

And then you need to modify build.gradle of SignalAndroid and move mavenLocal() to the top of the repository list. Then it should pull the library from the local repository.

If this works you should get an error while compiling that the signature of the library is wrong. Then remove the signature from the list of signatures in build.gradle and now everything should run without error :)

@Eskuero
Copy link
Author

Eskuero commented Sep 8, 2019

Thanks!
I managed to follow your instructions successfully and had no trouble integrating them on my building setup so I'm closing this.

Two days after testing it's definetely better than it used to be. The RAM usage of the background process seems more stable as well. In the past I have seen it ramp up to more than 150MB but now is usually stable below 80MB.

For anyone interested I'm publishing it on my Fdroid's Nightly App Repo
https://repo.eskuero.me/

@Eskuero Eskuero closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants